Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation.yaml #3

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Add validation.yaml #3

merged 3 commits into from
Jul 7, 2023

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Jul 6, 2023 •
edited
Loading

Check if:

  • local.minio.enabled is correct with regards to the other databases
  • connection details are given if cloud logs etc is used
  • check if anything is enabled
  • check the list of namespaces to monitor is not empty

@MichelHollands
Add validation.yaml
67b1338 
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands
Add check to if anything is enabled
116586e 
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands
Add check for empty list of namespaces to monitor
a14b072 
Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
@MichelHollands MichelHollands marked this pull request as ready for review July 6, 2023 13:12
trevorwhitney
trevorwhitney approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@MichelHollands MichelHollands merged commit a1cd5d3 into main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelHollands @trevorwhitney