orgid -1 -> 0

[Dieterbe]

can we make the "special org", currently at id=-1 , id=0 instead?
this help to encode orgid's, we can make them uints and save space

the only use of -1 that i'm aware of is for "globally visible data" that any org can see.
and we currently don't use 0. (we do use 1 for the admin org), so this should be pretty easy

[woodsaj]

That is fine with me

[Dieterbe]

k, this is low prio though, will probably address this at some point down the road.

[woodsaj]

So we cant use 0, as the metrics get rejected for being invalid.

https://snapshot.raintank.io/dashboard/snapshot/OM37FFnSW8MVfadRv1u13mJjR2ewR8ED?refresh=30s&panelId=1&fullscreen&orgId=2

[woodsaj]

So as discussed in the PR, we need to make the PublicOrgId configurable, but lets default to 0

[Dieterbe]

I don't understand how you reason from the rejected-invalid problem to your proposal of "make the PublicOrgId configurable, but lets default to 0", as that would still not work because the default still would be rejected.
so it requires removing the org!=0 rule, which by itself should also solve this problem, so #882

[woodsaj]

I dont like the idea of removing the validation rule. It would be too easy for a bug to result in the orgId being the zero value. And this would result in all users being able to see the data being inserted.

So just make it configurable. a default of 0 can just be treated as public metrics being disabled.

[Dieterbe]

#883