Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Conversation

Dieterbe
Copy link
Contributor

No description provided.

so that org 0 is invalid and we don't accidentally publish public data
when we forget to set the proper value.
@Dieterbe Dieterbe requested a review from woodsaj April 10, 2018 07:09
@woodsaj
Copy link
Contributor

woodsaj commented Apr 10, 2018

Looks great @Dieterbe . Just need to fix the unit tests in idx/cassandra/cassandra_test.go The unit tests are adding series with the OrgId: idx.OrgIdPublic and when performing find requests is expecting these to included in the results. But as the default OrgIdPublic is 0, the entries are not returned.

@Dieterbe Dieterbe force-pushed the configurable-publicorgid branch from 10567db to 58fac01 Compare April 10, 2018 07:48
@Dieterbe Dieterbe force-pushed the configurable-publicorgid branch from 58fac01 to e72b7e4 Compare April 10, 2018 07:58
@Dieterbe Dieterbe merged commit cedc438 into master Apr 10, 2018
@Dieterbe Dieterbe mentioned this pull request Apr 10, 2018
@Dieterbe Dieterbe deleted the configurable-publicorgid branch April 20, 2018 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants