Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

WIP: batch points in kafka messages #1032

Closed
wants to merge 1 commit into from
Closed

Conversation

woodsaj
Copy link
Member

@woodsaj woodsaj commented Sep 6, 2018

No description provided.

@woodsaj woodsaj mentioned this pull request Sep 6, 2018
@Dieterbe
Copy link
Contributor

Dieterbe commented Sep 6, 2018

interesting. do you have instructions to start kafka to repeat this experiment? can we just use the service as defined in one of the docker stacks?

@woodsaj
Copy link
Member Author

woodsaj commented Sep 6, 2018

do you have instructions to start kafka to repeat this experiment

docker run -d -p 9092:9092 -p 2181:2181  --name kafka -h localhost raintank/kafka

@replay
Copy link
Contributor

replay commented Sep 6, 2018

nice. if tsdb needs to batch the msgs before submitting to kafka, does that mean that crng will have to wait longer until it gets the acknowledgement? if we deploy that change we might need to tell the customers to increase their crng concurrency

@woodsaj
Copy link
Member Author

woodsaj commented Sep 6, 2018

@replay see #1002

short answer. yes, but we already do that. Kafka messages are already sent over the wire in batches. We already buffer in memory then flush to kafka, then ack the POST from crng. So this change wouldnt alter the crng->tsdb-gw interaction much. We would still be sending the same number of metrics in each "batch" sent to kafka, the only difference is that instead of sending a batch of 5000 metrics in a batch of 5000 kafka messages, we would be sending 5000 metrics in a batch of 50 kafka messages.

@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 4, 2020
@stale stale bot closed this Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants