This repository was archived by the owner on Aug 23, 2023. It is now read-only.
fix docker log levels #1083
Merged
fix docker log levels #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
reviewed
Oct 4, 2018
| @@ -13,7 +13,7 @@ Settings within section names in the config just require you to prefix the secti | |||
| Examples: | |||
|
|
|||
| ``` | |||
| MT_LOG_LEVEL: 1 # MT_<setting_name> | |||
| MT_LOG_LEVEL: info # MT_<setting_name> | |||
There was a problem hiding this comment.
in same places in this PR you're replacing 2 with info, and here you replace 1 with info. are they the same or should that be something else?
There was a problem hiding this comment.
'1' would be the new equivalent of 'debug', however that is a discrepancy between the documentation and the actual config / example config, so I thought it best to change the docs to match up with the config files themselves. Otherwise it might lead to confusion if someone looks at the docs and just assumes that the configs match them.
replay
approved these changes
Oct 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when I was spinning up docker-cluster