This repository was archived by the owner on Aug 23, 2023. It is now read-only.
prevent integer values overflowing our index datatypes #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
reviewed
Nov 16, 2018
DanCech
reviewed
Nov 16, 2018
replay
reviewed
Nov 16, 2018
the cassandra index uses 'int' type which is a 32bit signed integer. If we allow extremely high interval and timestamp values then we will get errors trying to update index in cassandra, which will keep retrying and blocking metrictank.
Dieterbe
force-pushed
the
cap-int-limits
branch
from
5295e56 to
7572f4b
Compare
DanCech
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cassandra index uses 'int' type which is a 32bit signed integer.
If we allow extremely high interval and timestamp values then
we will get errors trying to update index in cassandra, which will
keep retrying and blocking metrictank.