-
Notifications
You must be signed in to change notification settings - Fork 107
Conversation
this is a very cool idea. I notice the api does unsafe (unsynchronized) access to the variables though. |
let me know if you're not able to work on this anymore, i may be able to take over. |
Hi @Dieterbe , Right. Just added simple mutex (single for both calls, not sure if good idea) - or I can add 2 separate ones. |
i realized it's not proper in the kafka mdm input plugin to look at the cluster.MaxPrio setting because maxprio/readyness state is a concern for the cluster only, not input plugins. i have some WIP code for this that i can push soon |
@Dieterbe : yes, that's much cleaner, indeed. You decided not to implement api part? That's fine, just curious. |
yes. not a real need for it. |
Rationale:
when using Kafka input during startup of the node and initial backfill consumption I noticed 50-100% more memory consumption than during normal work.
I tried to mitigate that using GOGC environment variable - but then I found out that it obviously aggressive GOGC affecting rendering performance - and that increased GC pressure is not needed anymore because memory consumption is already lowered.
So, I implemented GOGC control through config file -
gogc-startup
variable in[kafka-mdm-in]
section controls GOGC for program startup,gogc-ready
- for normal work.I also implemented HTTP API for changing these vars, but that part is probably optional.