This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Refactor releases #1177
Merged
Refactor releases #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
refactor-releases
branch
from
596204a to
505f33a
Compare
Dieterbe
force-pushed
the
refactor-releases
branch
3 times, most recently
from
1296c0c to
e0e0f8a
Compare
|
currently not building cause circleci doesn't have go 1.11.4 yet. i imagine that'll be addressed shortly. |
the main problem this solves is that users want to be able to see the changelog for unreleased versions, whereas on GitHub releases page you can only show changelog after making the release.
no need for -<commit>-<hash> suffix if we're right on a tag
the main problem we solve here is that currently, people just install the latest package, or run the latest docker image, and occasionally something in master hasn't had the chance yet to be battle tested in production. We want to make it safer for them to run metrictank, by guiding them towards the latest stable releases, which are tagged after we feel more confident about the code in master. while we're at it, make sure we consistently set version/tag everywhere
note, all version tags will now be e.g. `v1.0` rather than `1.0`, for no strong reason other than it just looks a bit slicker. the distribution packages use the latter, because I think tools like deb/rpm will start complaining otherwise. But everywhere else, (docker/gcr tags, mt-qa, app reporting its own version in logs and metrics) we use the one with `v` prefix whereas we did not before.
* it's the version, not the git hash * runtime.Version() prints "go" if it's go, so no need to mention anymore * put app version first cause we care more about it * easier to parse format
Dieterbe
force-pushed
the
refactor-releases
branch
from
e0e0f8a to
3161e0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal is to do the same as
grafana/carbon-relay-ng#330
grafana/carbon-relay-ng#331
also getting ready to issue another major release: 0.11.0
please have a look at the latest changelog entry for the upcomining release and give me a +1 or some feedback, thanks. and let me know is there any reason why i wouldn't tag 0.11.0 after merging this PR.
thanks.