debug build of metrictank and debug docker/k8s images #1187
Conversation
|
need to update docs/docker.md |
| COPY config/schema-store-cassandra.toml /etc/metrictank/schema-store-cassandra.toml | ||
| COPY config/schema-idx-cassandra.toml /etc/metrictank/schema-idx-cassandra.toml | ||
| COPY config/schema-store-scylladb.toml /usr/share/metrictank/examples/schema-store-scylladb.toml | ||
| COPY config/schema-idx-scylladb.toml /usr/share/metrictank/examples/schema-idx-scylladb.toml |
There was a problem hiding this comment.
can't we do this without repeating all the stuff we did for the regular image?
maybe use FROM metrictank ? (obviously, requires that image to be built before building this one)
| } | ||
|
|
||
| trap 'kill_metrictank' SIGTERM | ||
| trap 'kill_metrictank' SIGINT |
There was a problem hiding this comment.
do we need all this stuff because when terminating delve, it doesn't terminate metrictank?
you need to describe the problem and the solution in a comment.
There was a problem hiding this comment.
Yes it doesn't properly terminate Metrictank and then the container hangs. I will document it in a comment.
There was a problem hiding this comment.
it's unfortunate, all the complexity we have to add to deal with this..
can we solve this in a more clean way, e.g. add support to delve to properly kill its child process when it is terminated? or is it a design goal to keep the child alive?
There was a problem hiding this comment.
I'm looking into other possible options or flags to use that might accomplish this.
There was a problem hiding this comment.
I haven't been able to find another way to get this done.
|
please keep commit messages more highlevel. there's not much value to them if they are as detailed and verbose as the actual diff is. |
robert-milan
changed the title
robert-milan
force-pushed
the
remote-debug
branch
from
fe7c811 to
07d3b72
Compare
|
@robert-milan is this ready to merge in your opinion? |
I believe so, I would like to have a day or two more just to look over it again. |
add docker-dev-debug for running local metrictank with dlv in container add -debug flag for use with build scripts add Dockerfiles for local and kubernetes versions add metrictank-debug image for public and private repositories
update Makefile to include qa for debug builds remove metrictank-debug versions of docker images add debug tags to existing metrictank docker images to differentiate them from normal builds add debug after version name of metrictank remove exec command from startup scripts in order to trap signals and gracefully exit metrictank and dlv
minor diff with stock docker config, may as well use it.
Dieterbe
changed the title
add docker-dev-debug for running local metrictank with dlv in container
add -debug flag for use with build scripts
add Dockerfiles for local and kubernetes versions
add .vscode to .gitignore
add metrictank-debug image for public and private repositories