Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

update kafka docs and defaults to v2.0.0 #1221

Merged
merged 2 commits into from
Mar 26, 2019
Merged

update kafka docs and defaults to v2.0.0 #1221

merged 2 commits into from
Mar 26, 2019

Conversation

Dieterbe
Copy link
Contributor

No description provided.

@Dieterbe
Copy link
Contributor Author

we should also update all configs and built-in defaults to use kafka version v2.0

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dieterbe
Copy link
Contributor Author

I have:

  1. updated https://hub.docker.com/r/raintank/kafka to make latest point to v2 (commands used docker tag raintank/kafka:v2.0.0 raintank/kafka:latest && docker push raintank/kafka:latest). no need to update docker stack configs because they all already use "latest"
  2. updated kafka-version = 2.0 for both kafka plugins in all configs and built-in defaults
  3. tested in docker-dev-custom-cfg-kafka with offset oldest and newest (and fakemetrics). behaves fine

I think this should do it. @robert-milan anything else I forgot? I thought our config file(s) had other settings related to kafka version, but apparently not.

@Dieterbe Dieterbe force-pushed the update-kafka-docs branch from 6d4654b to 836bc3b Compare March 25, 2019 11:27
@Dieterbe Dieterbe force-pushed the update-kafka-docs branch from 836bc3b to d91671b Compare March 25, 2019 11:28
@Dieterbe Dieterbe changed the title update kafka docs update kafka docs and defaults to v2.0.0 Mar 25, 2019
@woodsaj
Copy link
Member

woodsaj commented Mar 25, 2019

no need to update docker stack configs because they all already use "latest"

existing users will need to run docker pull raintank/kafka to have their local image updated to the new version.

@Dieterbe
Copy link
Contributor Author

@woodsaj sure but does that mean anything should change in this PR?

@woodsaj
Copy link
Member

woodsaj commented Mar 26, 2019

Nope, just drawing attention to the fact.

@Dieterbe Dieterbe merged commit 59ebb22 into master Mar 26, 2019
@Dieterbe Dieterbe deleted the update-kafka-docs branch March 27, 2019 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants