This repository was archived by the owner on Aug 23, 2023. It is now read-only.
remove log-min-dur #1275
Merged
remove log-min-dur #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsaj
approved these changes
Apr 10, 2019
introduced via 929513c / #174 became obsolete in b3d3831 / #575 / 0.7.1-61-gbe64803e we no longer really log requests ourselves anymore. i imagine at some point we probably will, at which point we can re-introduce this setting (our qa tool `unused` notified that this variable wasn't being read anywhere)
Dieterbe
force-pushed
the
deprecate-log-min-dur
branch
from
3a47065 to
ee77e88
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced via 929513c / #174
became obsolete in b3d3831 / #575 / 0.7.1-61-gbe64803e
we no longer really log requests ourselves anymore.
i imagine at some point we probably will, at which point we can
re-introduce this setting
(our qa tool
unusednotified that this variable wasn't being readanywhere)