This repository was archived by the owner on Aug 23, 2023. It is now read-only.
NotifierKafka: fix case when partition is empty (avoid hitting timeout) #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkaleo
force-pushed
the
nowait_when_no_messages2
branch
from
734d02b to
252c083
Compare
replay
reviewed
Jun 20, 2019
mdata/notifierKafka/notifierKafka.go
Outdated
| @@ -128,6 +128,10 @@ func (c *NotifierKafka) start() { | |||
| } | |||
| } | |||
|
|
|||
| if startOffset < 0 { | |||
| log.Infof("kafka-cluster: empty partition, nothing to consume") | |||
| continue | |||
There was a problem hiding this comment.
if we do that, we're not going to consume it if data gets pushed into this partition in the future
There was a problem hiding this comment.
Please ignore my complete dumb-ness. I'll just fix the lastReadOffset in consumePartition like I originally said.
fkaleo
force-pushed
the
nowait_when_no_messages2
branch
from
252c083 to
6354efc
Compare
fkaleo
force-pushed
the
nowait_when_no_messages2
branch
from
6354efc to
16eaf01
Compare
robert-milan
approved these changes
Jun 21, 2019
Dieterbe
reviewed
Jun 21, 2019
| lastReadOffset := startOffset - 1 | ||
| var lastReadOffset int64 | ||
| if startOffset < 0 { | ||
| log.Infof("kafka-cluster: empty partition") |
There was a problem hiding this comment.
should probably mention which partition..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.