Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Add native substr() processing function #1363

Merged
merged 8 commits into from
Aug 27, 2020
Merged

Add native substr() processing function #1363

merged 8 commits into from
Aug 27, 2020

Conversation

robert-milan
Copy link
Contributor

updates #1318

@robert-milan robert-milan requested a review from Dieterbe June 24, 2019 18:42
@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 4, 2020
@Dieterbe Dieterbe removed the stale label Apr 7, 2020
@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 6, 2020
@stale stale bot closed this Jul 13, 2020
@robert-milan robert-milan reopened this Jul 15, 2020
@Dieterbe Dieterbe added this to the sprint-16 milestone Aug 24, 2020
the-real-stiven and others added 8 commits August 27, 2020 14:32
@the-real-stiven @Dieterbe
added substr function
ea3032d
@the-real-stiven @Dieterbe
fixed indexing and series not being updated
bcbfd08
@the-real-stiven @Dieterbe
added test
caec6bf 
made stable
@the-real-stiven @Dieterbe
add boundary checks
5f85876
@robert-milan @Dieterbe
Remove pool caching
7ea1454
@Dieterbe
use new testing paradigm
db69c37
@Dieterbe
rebase on master
fd7adc1
@Dieterbe
Revert most of "Remove pool caching"
9987fa2 
This reverts commit 1df4f8b2c685b61571126dbc5addc0d36d2107c4.
Since we are not creating a new pointslice, we don't want to double-add
the same slice to the cache, BUT we MAY NOT make modifications to the
input series
@Dieterbe
Copy link
Contributor

@robert-milan please have a look at the commits I pushed.

@Dieterbe Dieterbe changed the title Substr Add native substr() processing function Aug 27, 2020
@Dieterbe Dieterbe merged commit a2ebc4d into master Aug 27, 2020
@Dieterbe Dieterbe deleted the substr branch August 27, 2020 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dieterbe Dieterbe Dieterbe approved these changes

Assignees

@Dieterbe Dieterbe

Labels
None yet
Projects
None yet
Milestone
sprint-16
Development

Successfully merging this pull request may close these issues.
3 participants
@robert-milan @Dieterbe @the-real-stiven