Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Move tag query evaluation logic into tag expressions #1373

Merged
merged 40 commits into from
Aug 9, 2019
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
7c5fb6e
make tag query expression an interface with one type per operator
replay Jun 28, 2019
46b2863
use the new expression types when running queries
replay Jun 29, 2019
36c2cfa
fix expression tests
replay Jun 29, 2019
05845d6
simplify query struct
replay Jun 29, 2019
4d70df9
fix test
replay Jul 4, 2019
8e403ef
add unit test for the indexes meta-tag-record interface
replay Jul 5, 2019
521ec1d
rename meta tag record member queries to expressions
replay Jul 5, 2019
bcbb757
add special expression to match all/none
replay Jul 5, 2019
6e9830a
add test to test various combinations of tag query expressions
replay Jul 15, 2019
22b1661
consistent method ordering and comments in expressions
replay Jul 15, 2019
429ff37
performance improvements
replay Jul 16, 2019
4e852bc
move matchCache config to tagquery pkg
replay Jul 16, 2019
0cc49e6
update example configs and changelog
replay Jul 16, 2019
eb1e25a
cleanup
replay Jul 16, 2019
9c6cc1b
make meta tag support optional
replay Jul 17, 2019
c1a30ab
optimize performance by using map lookup
replay Jul 17, 2019
3fbdf49
cleanup, only syntax
replay Jul 17, 2019
4f6ed8f
use cost estimation
replay Jul 18, 2019
4a5892b
use direct key lookup if possible
replay Jul 18, 2019
dee5a34
fix tests
replay Jul 18, 2019
480706f
cleaner way to build error
Dieterbe Jul 29, 2019
d5da8f1
better comments
Dieterbe Jul 29, 2019
e3be86e
remove dead code 'HasRe'
Dieterbe Jul 29, 2019
e748c64
move tag query options into memory index
replay Jul 30, 2019
667e2f6
add comparison methods to meta tag records and expression types
replay Jul 30, 2019
f19b46d
add HashExpression method to meta tag record type
replay Jul 30, 2019
954172b
add comment
replay Jul 30, 2019
6a53c6f
adding comments
replay Jul 30, 2019
5935500
update comment
replay Jul 30, 2019
13059a0
faster meta tag record comparison
replay Jul 30, 2019
b1df23b
update docs to reflect config parameter changes
replay Jul 31, 2019
bafc023
more comments to explain type Expression
replay Aug 1, 2019
830f42f
fix json response format bug
replay Aug 3, 2019
590aaa5
fix bug when initial expression has type HAS_TAG
replay Aug 6, 2019
9d516c8
better naming and additional comment
replay Aug 6, 2019
bc6c8b7
performance tuning
replay Aug 6, 2019
142a893
fix benchmark TagQueryKeysByPrefixSimple
replay Aug 6, 2019
e565d55
Apply suggestions from code review
replay Aug 8, 2019
aefbc3c
initialize index settings into local variables
replay Aug 8, 2019
3103854
bugfix in expression_not_has_tag
replay Aug 8, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix benchmark TagQueryKeysByPrefixSimple
replay committed Aug 7, 2019

Verified

This commit was signed with the committer’s verified signature.
replay Mauro Stettler
commit 142a89333372153e21b36acfa0f861fdf6dea83c
4 changes: 1 addition & 3 deletions idx/memory/memory_find_test.go
Original file line number Diff line number Diff line change
@@ -1219,14 +1219,12 @@ func benchmarkTagQueryKeysByPrefixSimple(b *testing.B) {

type testCase struct {
prefix string
expr []string
from int64
expRes []string
}

tc := testCase{
prefix: "di",
expr: []string{},
from: 100,
expRes: []string{"direction", "disk"},
}
@@ -1235,7 +1233,7 @@ func benchmarkTagQueryKeysByPrefixSimple(b *testing.B) {
b.ResetTimer()

for n := 0; n < b.N; n++ {
autoCompleteTagsWithQueryAndCompare(b, n, tc.prefix, tc.expr, tc.from, 2, tc.expRes)
autoCompleteTagsAndCompare(b, n, tc.prefix, tc.from, 2, tc.expRes)
}
}