This repository was archived by the owner on Aug 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeb986e
to
448d427
Compare
note to self, this patch was helpful to see what's going on
|
b9c22f3
to
8453a66
Compare
Dieterbe
commented
Sep 11, 2019
3ac0933
to
b8472f9
Compare
this allows us to do less work if the context is canceled
checking req.Archive is more robust. checking consolidator worked, because newRequestContext is only being called by getSeriesFixed, which would only specify consolidator.None in case req.Archive == 0 (noting that req.Consolidator must be > 0, as set by executePlan) but relying on that is convoluted. just get the signal from the source. (and newRequestContext is also called by two tests which leave req.Consolidator 0 where they would pass consolidator.None)
because it is not always stable
...with the concept of canonical series. Note that we started using rctx.From and rctx.To as parameters to Fix(), not req.From and req.To Aside from the new pre-canonicalization tweak in newRequestContext(), this is equivalent.
b8472f9
to
ecc8d55
Compare
fkaleo
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
should also fix #761 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document concepts better and in particular introduce new concept of a "canonical series".
Now we massage the fetch and fix parameters such that a high resolution series will always look like a native lower resolution serie (one that has the same interval as what we're normalizing to).
In particular, they will now have corresponding timestamps, and the same amount of points.
fix #913 (panic in mergeSeries) - tried the repro case. can't repro anymore.
fix #1095 (mergeSeries and sumSeries) - can not repo either one with this code.
fix #874 (dupe)