This repository was archived by the owner on Aug 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
Reject datapoints with timestamp too far in the future #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do I understand this correctly? I thought this restriction would apply with respect to the TTL of the archive you're submitting to. (so if sending 1s data, it should only allow `now + 7d *10/100 ? |
woodsaj
reviewed
Dec 16, 2019
946f31b
to
9d5fbb2
Compare
9d5fbb2
to
12caf3e
Compare
woodsaj
reviewed
Dec 16, 2019
woodsaj
reviewed
Dec 17, 2019
woodsaj
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new setting called
future-tolerance-ratio
.This is the implementation of what's described in this comment: #1560 (comment)
Fixes #1560