This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Add minimal HTTP gateway #1602
Merged
Add minimal HTTP gateway #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzoh
commented
Jan 13, 2020
fitzoh
commented
Jan 13, 2020
fitzoh
commented
Jan 13, 2020
fitzoh
commented
Jan 13, 2020
fitzoh
commented
Jan 13, 2020
|
More thoughts: |
this tool is simple enough. all the components are individually tested, and this just ties it together. I don't think we need additional testing here.
for now, just put it in the tool's output, that way it'll also go into docs/tools.md |
fitzoh
force-pushed
the
http-gateway-initial
branch
from
72f750e to
7531acf
Compare
|
rebased to pull in #1604 |
fitzoh
commented
Jan 14, 2020
woodsaj
reviewed
Jan 15, 2020
replay
reviewed
Jan 16, 2020
fitzoh
commented
Jan 16, 2020
…to record the http status in the middleware
replay
reviewed
Jan 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for grafana/metrictank-ops#542.
The direct proxies to metrictank (that don't require a rewrite) are implemented, others are essentially a placeholder at the moment.