Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

change tooltip to display individual values #1618

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

robert-milan
Copy link
Contributor

@robert-milan robert-milan commented Jan 20, 2020

Previously the values in the Chunk Cache panel were being displayed as the cumulative of the stack which was causing some confusion.

Pre-change (notice the tooltip on the bottom of the screenshot):
pre-change

Post-change (notice the tooltip on the bottom of the screenshot):
post-change

@robert-milan robert-milan requested a review from a team January 20, 2020 11:24
@replay
Copy link
Contributor

replay commented Jan 20, 2020

just out of curiosity, could you show two screenshots illustrating the difference?

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-milan robert-milan merged commit 5a50dc7 into master Jan 20, 2020
@robert-milan robert-milan deleted the fix-chunk-cache-panel branch January 20, 2020 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants