This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Add standalone Docker image for mt-gateway #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzoh
commented
Jan 22, 2020
fitzoh
commented
Jan 22, 2020
fitzoh
commented
Jan 22, 2020
| @@ -14,6 +14,10 @@ then | |||
| docker tag grafana/metrictank grafana/metrictank:$tag | |||
| docker tag grafana/metrictank grafana/metrictank:$version | |||
|
|
|||
| docker build -t grafana/mt-gateway --target=mt-gateway -f ${DIR}/Dockerfile . | |||
| docker tag grafana/mt-gateway grafana/mt-gateway:$tag | |||
| docker tag grafana/mt-gateway grafana/mt-gateway:$version | |||
There was a problem hiding this comment.
Is mt-gateway descriptive enough for the docker image name?
grafana/metrictank-gateway maybe?
There was a problem hiding this comment.
i think mt-gateway is fine. people will only come looking for this when they already looked into metrictank, and were linked to this.
our target users are not people who randomly browse around the internet, find this and say "hey i want to use this but i don't know what mt means"
There was a problem hiding this comment.
Do I need to have someone create the initial repository, or does that just automatically happen on push?
Would be nice to not have the build break on merge
fitzoh
force-pushed
the
mt-gateway-docker-image
branch
2 times, most recently
from
b51cfa1 to
6954128
Compare
fitzoh
force-pushed
the
mt-gateway-docker-image
branch
from
560a595 to
c3dc215
Compare
Dieterbe
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
mt-gatewaytarget to the existing Dockerfile.Currently only publishes to dockerhub (no gcr)