-
Notifications
You must be signed in to change notification settings - Fork 107
Conversation
this seems weird. especially because so many settings that are normally shared (hosts, keyspace, auth, timeout, ...) are now duplicated. Why would anyone want to store half of their index data in one cassandra cluster and the other half in a different cluster (or keyspace)? This seems very unlikely and unnecessarily complicated. |
The idea is to split the whole meta tag index away from the current main index and into it's pkg. I could just copy the config settings of the main index into the meta tag index as well, but then why did we split the store and the index into separate config sections? Isn't the argument there to just provide as much flexibility as possible? |
01c4ee3
to
1009fbc
Compare
6ad70f7
to
a394c59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things to start
e873d79
to
f1361c2
Compare
this type gets moved into the type idx because we'll also want to use it from the bigtable meta records index.
41db82a
to
674979f
Compare
b128cc3
to
674979f
Compare
to make it reusable by other packages. will be used by the cassandra index, store and meta record index
I rebased this PR and went over all the changes one more time to make sure everything is ok, and to familiarize myself with it again. I didn't make any large changes, @robert-milan you should be able to see the diff of the changes I made today by doing Out of all the changes I made, the largest one was in If you're still ok with these recent changes, then I'll go ahead and merge. |
Sure, go ahead |
This implements storing meta records in a new bigtable meta record index. Additionally it refactors the cassandra index so that the meta record index is now also split from the rest of the cassandra index in it's own pkg. It moves some of the config parameters for the cassandra backed meta record index around, so if this code change gets accepted then i'll update the breaking changes log accordingly.