This repository was archived by the owner on Aug 23, 2023. It is now read-only.
fix: mergeSeries() should normalize its inputs + normalize() bugfix + cleanups #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have this particular map of series slices that we use in many places that we use for a few very particular use cases. It went by various name: data, cache, input, ... Now we make it clear that it's the same everywhere: dataMap
Dieterbe
changed the title
Dieterbe
changed the title
where a lower-resolution final point may lead to a consolidated point to be higher than what canonical last point would be
Dieterbe
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably easiest to review commit by commit
in #951 we forgot to add normalization to mergeSeries() to deal with series changing intervals. and also there was a bug in normalize() which is now fixed
I also tested this in docker-dev-custom-cfg-kafka. by using fakemetrics to first send some 1s data and then switching to 4s. before this patch, it would intermittenly error, with this patch, it works fine.