This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Add constantLine function #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some formatting issues which make the circleCI tests fail |
Dieterbe
reviewed
Mar 30, 2020
| schema.Point{Val: s.value, Ts: s.from}, | ||
| schema.Point{Val: s.value, Ts: s.from + uint32((s.to-s.from)/2.0)}, | ||
| schema.Point{Val: s.value, Ts: s.to}, | ||
| ) |
There was a problem hiding this comment.
it is guaranteed at this point (due to prior validation) that from < to.
however, from may equal to -1, which would result in duplicate timestamps. this is an edge case, and causes graphite to crash, but we may as well handle it :)
Dieterbe
suggested changes
Mar 30, 2020
|
I added bloomberg@38e1c21 10 minutes ago, but not showing up here. There was some wonky stuff that happened over weekend where the original branch got deleted, so if the commit doesn't show up here by EOD, I'll close this PR and make a new one. |
|
closing per comment above ^ - will create new PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds the constantLine function
Testing performed
Test files added with mtcmptest used locally