This repository was archived by the owner on Aug 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
Adds aggregateWithWildcards (and sum / multiply / avg) #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in docker-dev, issuing this query on graphite, I get these 2 series:
on MT, I get:
|
Dieterbe
reviewed
Aug 5, 2020
Dieterbe
reviewed
Aug 5, 2020
Dieterbe
reviewed
Aug 5, 2020
Dieterbe
reviewed
Aug 5, 2020
Dieterbe
reviewed
Aug 5, 2020
@robert-milan I added some commits. now it seems to work like graphite in all my tests. |
FWIW I used https://github.com/shanson7/mtcmptest to compare MT and graphite responses |
Thanks Dieter, looks good. |
Dieterbe
approved these changes
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds aggregateWithWildcards and sumSeriesWithWildcards, multiplySeriesWithWildcards, and averageSeriesWithWildcards
I have tested it locally against sumSeries, averageSeries, and multiplySeries and it appears to be working properly.