Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

leverage in-flight requests of other replicas to possibly overcome shard query errors #1869

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Aug 3, 2020

fix #1817

one interesting case is what happens when an error comes in, and there are more replicas available for querying, as well as a request in flight (you can have this with replicas >= 3)

we could do two things here:

  1. wait until the in-flight response comes in, and only when an error comes back for it, try the 3rd replica
  2. initiate request to 3rd replica, resulting in 2 in flight requests (and a total of 3 for the given shard)

I've opted for number 2.

@Dieterbe Dieterbe force-pushed the fix-spec-exec-err-but-inflight branch from a588d9e to 77e967b Compare August 3, 2020 19:35
@Dieterbe Dieterbe force-pushed the fix-spec-exec-err-but-inflight branch from 77e967b to d92692a Compare August 3, 2020 19:48
@Dieterbe Dieterbe requested a review from shanson7 August 3, 2020 20:02
Copy link
Collaborator

@shanson7 shanson7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Overall looks much cleaner!

@Dieterbe Dieterbe merged commit e085017 into master Aug 4, 2020
@Dieterbe Dieterbe deleted the fix-spec-exec-err-but-inflight branch August 4, 2020 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speculative query failure causes request failure
2 participants