This repository was archived by the owner on Aug 23, 2023. It is now read-only.
experimental: add kafka-all plugin for metrics + clustering #264
+369
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see #263 (comment) I'm actually not a big fan anymore of this approach, maybe we can do something simpler tasks left todo: * test this * partKey for usage metrics? * add metadata blocks to messages to differentiate between metrics and metricpersist messages. integrating this into existing stack is going to be messy.
|
maybe later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #263 (comment)
I'm actually not a big fan anymore of this approach, maybe we can do something simpler. especially since we now have a new prod environment that's up and running, and migrating to different clustering messages with different header etc is going to be messy.
I like @woodsaj's idea at #74 (comment)
tasks left todo if we want to persue this method:
integrating this into existing stack is going to be messy.