This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Persist partition #952
Merged
Persist partition #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
reviewed
Jun 27, 2018
| Key: sarama.ByteEncoder(key), | ||
| Topic: topic, | ||
| Value: sarama.ByteEncoder(buf.Bytes()), | ||
| Partition: def.Partition, |
shanson7
force-pushed
the
persistPartition
branch
from
402e053 to
26003a6
Compare
|
This one could probably be removed as well: https://github.com/bloomberg/metrictank/blob/26003a6ab728b7206539d764aa4a8e3fe469ccf8/docker/docker-cluster/metrictank.ini#L294 |
|
When upgrading from pre-this-commit to this commit, there should be no issues, right? Because the partition that gets assigned to the persist messages of a topic should remain the same as before |
|
Right. The only case where it should change is if it was doing the wrong thing before. |
woodsaj
approved these changes
Jul 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #950