This repository was archived by the owner on Aug 23, 2023. It is now read-only.
[wip] Meta Tag Index #960
Closed
[wip] Meta Tag Index #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
changed the title
replay
force-pushed
the
extrinsic_tags
branch
from
713883e to
196c685
Compare
replay
force-pushed
the
extrinsic_tags
branch
from
2d1aba3 to
7943d11
Compare
replay
changed the title
replay
force-pushed
the
extrinsic_tags
branch
from
1d1b455 to
306f10c
Compare
Dieterbe
reviewed
Jan 31, 2019
idx/memory/tag_query.go
Outdated
| NOT_MATCH // !=~ | ||
| PREFIX // ^= exact prefix, not regex. non-standard, required for auto complete of tag values | ||
| PREFIX_TAG // __tag^= exact prefix with tag. non-standard, required for auto complete of tag keys | ||
| OP_NONE match = iota |
There was a problem hiding this comment.
please:
- follow Go naming conventions. see https://stackoverflow.com/a/22688926/227168
- do renames and cleanups separate from your logical changes. ideally as a commit preceeding the rest, or even as a separate PR (if you order your commits properly, it's always easy to make separate branches and PR's)
replay
force-pushed
the
extrinsic_tags
branch
22 times, most recently
from
ed0af91 to
10f8ae4
Compare
![codelingo[bot]](https://avatars.githubusercontent.com/in/14339?s=60&v=4){kind=small}
replay
force-pushed
the
extrinsic_tags
branch
3 times, most recently
from
c1911b9 to
70c3a4f
Compare
replay
force-pushed
the
extrinsic_tags
branch
2 times, most recently
from
5087a2f to
bce27be
Compare
replay
force-pushed
the
extrinsic_tags
branch
6 times, most recently
from
19c75fb to
d715dfd
Compare
woodsaj
reviewed
Apr 3, 2019
| @@ -300,7 +300,7 @@ func parseDuration(s string) (time.Duration, error) { | |||
| func SeriesToSeriesSet(out []models.Series) (*models.PrometheusSeriesSet, error) { | |||
| series := []storage.Series{} | |||
| for _, metric := range out { | |||
| series = append(series, models.NewPrometheusSeries(buildTagSet(metric.Target), dataPointsToPrometheusSamplePairs(metric.Datapoints))) | |||
| series = append(series, models.NewPrometheusSeries(metric.Tags, dataPointsToPrometheusSamplePairs(metric.Datapoints))) | |||
There was a problem hiding this comment.
prometheus expects a "name" tag. But metric.Tags uses a "name" label.
replay
force-pushed
the
extrinsic_tags
branch
7 times, most recently
from
d77aa4b to
34c7312
Compare
replay
force-pushed
the
extrinsic_tags
branch
2 times, most recently
from
8bac270 to
d572c16
Compare
|
Closing this because I'm submitting it piece-by-piece instead of creating one gigantic PR, as described here: #660 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that's just a first prototype after some internal discussions. related to #660