Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Regen for test check #969

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Regen for test check #969

merged 1 commit into from
Aug 1, 2018

Conversation

shanson7
Copy link
Collaborator

Looks like some optimizations were added for msgp generated code. This caused a test to fail on another PR I was working and I figured I'd put in a smaller quick PR to get it fixed.

@shanson7 shanson7 requested a review from replay July 30, 2018 20:04
@shanson7
Copy link
Collaborator Author

Note: this is all generated code

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Out of curiosity: How did this make a test fail?

Edit: nvm, saw it: #945

@shanson7
Copy link
Collaborator Author

There is a check that generated files match after a fresh generation. See https://circleci.com/gh/grafana/metrictank/6443?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@shanson7
Copy link
Collaborator Author

shanson7 commented Aug 1, 2018

@replay can we merge this? I'm seeing other PR branches with these changes that are going to conflict. They can rebase off this once merged.

@replay replay merged commit b590cd2 into master Aug 1, 2018
@replay
Copy link
Contributor

replay commented Aug 1, 2018

@shanson7 sorry that it took a while, I assumed that once I approve it you'll be able to do the merge

@shanson7
Copy link
Collaborator Author

shanson7 commented Aug 1, 2018

Apparently I cannot :/

@shanson7 shanson7 deleted the regenTypes branch August 1, 2018 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants