Fix FastRegexMatcher to skip nested capture groups #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
deleted the
fix-regexp-optimization-with-double-capture-group
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FastRegexMatcherignores capture group by design. This is done callingclearCapture(). However,clearCapture()removes a single capture group. This means that when a regexp has nested capture groups (e.g.((a|b))) the optimization doesn't trigger because we remove the 1st capture group but not the 2nd (nested) one.This PR fixes it. To clarify, this is not a logic bug, but we're missing the opportunity to optimize regexp with nested capture groups.