OTLP: Convert Exponential histograms start timestamps into zero samples #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusvazquez
commented
Sep 20, 2024
| return | ||
| } | ||
|
|
||
| ts.Histograms = append(ts.Histograms, prompb.Histogram{Timestamp: startTs}) |
There was a problem hiding this comment.
I'd like to know if this is correct to specify the initial 0 for a histogram cc @krajorama
There was a problem hiding this comment.
yes, empty histogram is valid because schema 0 is defined, and it's ok to have no buckets
krajorama
approved these changes
Sep 20, 2024
jesusvazquez
deleted the
jvp/handle-start-time-for-native-histograms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to #684 and #689 where we add the same logic but for exponential histograms.
Unit tests included.