Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Commit a "golden-record" of the chart output #2032

Closed
Logiraptor opened this issue Jun 6, 2022 · 0 comments · Fixed by #2034
Closed

Helm: Commit a "golden-record" of the chart output #2032

Logiraptor opened this issue Jun 6, 2022 · 0 comments · Fixed by #2034
Assignees
Labels

Comments

@Logiraptor
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It can be difficult to understand what has changed in a given Helm-chart related PR.

Describe the solution you'd like

We should commit a compiled version of the Helm chart, just like we do for the jsonnet library. A PR check should enforce that the compile step has been run to keep it up to date.

Describe alternatives you've considered

Nothing really

Additional context

This is a prerequisite to support another PR check in the future: automatic diffing between the jsonnet and Helm output.

@Logiraptor Logiraptor self-assigned this Jun 6, 2022
@pracucci pracucci added the helm label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants