Add a helm golden record #2034
Merged
Add a helm golden record #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logiraptor
force-pushed
the
logiraptor/helm-golden-record
branch
from
a429c2c to
245cb85
Compare
Logiraptor
force-pushed
the
logiraptor/helm-golden-record
branch
from
e528148 to
1f28881
Compare
Set kubeVersionOverride to generate PodDisruptionBudget API version consistently. When I ran the test, I got a diff, because my k8s is newer (1.23). Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
dimitarvdimitrov
approved these changes
Jun 7, 2022
krajorama
approved these changes
Jun 7, 2022
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a compiled version of the helm chart, useful for validating Helm PRs and later for comparing jsonnet to helm.
The build script re-uses helm's chart-testing tool conventions. In other words, any installation tests we add to the
cidirectory will have golden records generated.The diff is mostly from generated files, just the first four files are relevant:
Which issue(s) this PR fixes or relates to
Fixes #2032
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]