Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled #8683

Closed
bboreham opened this issue Jul 11, 2024 · 3 comments · Fixed by #9397
Closed

Flaky TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled #8683

bboreham opened this issue Jul 11, 2024 · 3 comments · Fixed by #9397
Assignees
@charleskorn
Labels
type/tests

Comments

@bboreham
Copy link
Contributor

Failed: https://github.com/grafana/mimir/actions/runs/9892110218/job/27324029029?pr=8681
Passed: https://github.com/grafana/mimir/actions/runs/9892110218/job/27325382838?pr=8681

--- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled (0.01s)
    --- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks() (0.00s)
        block_streaming_test.go:357: 
            	Error Trace:	/__w/mimir/mimir/pkg/querier/block_streaming_test.go:357
            	            				/__w/mimir/mimir/pkg/querier/block_streaming_test.go:396
            	Error:      	expected GetChunks to report context cancellation error before reaching end of stream
            	Test:       	TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks()
FAIL
@pstibrany
Copy link
Member

https://github.com/grafana/mimir/actions/runs/10845840398/job/30097560337?pr=9271

@charleskorn charleskorn self-assigned this Sep 22, 2024
@charleskorn
Copy link
Contributor

I can reliably trigger this failure locally with ~4 failures in every 100000 attempts:

$ go test -run="TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled" -count=100000 -timeout=1h .
--- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled (0.01s)
    --- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks() (0.00s)
        block_streaming_test.go:357:
            	Error Trace:	/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:357
            	            				/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:396
            	Error:      	expected GetChunks to report context cancellation error before reaching end of stream
            	Test:       	TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks()
--- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled (0.01s)
    --- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks() (0.00s)
        block_streaming_test.go:357:
            	Error Trace:	/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:357
            	            				/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:396
            	Error:      	expected GetChunks to report context cancellation error before reaching end of stream
            	Test:       	TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks()
--- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled (0.01s)
    --- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks() (0.00s)
        block_streaming_test.go:357:
            	Error Trace:	/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:357
            	            				/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:396
            	Error:      	expected GetChunks to report context cancellation error before reaching end of stream
            	Test:       	TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks()
--- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled (0.01s)
    --- FAIL: TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks() (0.00s)
        block_streaming_test.go:357:
            	Error Trace:	/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:357
            	            				/Users/charleskorn/Repositories/Grafana/mimir/pkg/querier/block_streaming_test.go:396
            	Error:      	expected GetChunks to report context cancellation error before reaching end of stream
            	Test:       	TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled/GetChunks()
FAIL
FAIL	github.com/grafana/mimir/pkg/querier	2251.367s
FAIL

@charleskorn charleskorn mentioned this issue Sep 25, 2024
Merged
@charleskorn
Copy link
Contributor

Should be fixed by #9397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleskorn charleskorn

Labels
type/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flaky TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled grafana/mimir
3 participants
@pstibrany @charleskorn @bboreham