Fix flaky TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled
#9397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a flaky test,
TestStoreGatewayStreamReader_AbortsWhenParentContextCancelled.Theoretically this failure could also happen in the real world, but realistically it's unlikely to happen, and if it did, then a user would get a result for their cancelled query rather than an error saying it was cancelled. So there's no user-visible impact if the failure condition was triggered.
For this reason I don't think this is worthy of a changelog entry, open to other opinions though.
Which issue(s) this PR fixes or relates to
Resolves #8683
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.