Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release mimir-distributed-beta to helm-charts repo #1948

Merged
merged 1 commit into from
Jun 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/helm-release.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: helm-release

on:
push:
branches:
- helm-release-test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only on this specific branch? What's the expected workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was for testing only, not going to enable on main until I'm 100% sure it doesn't break our CI/CD


jobs:
call-update-helm-repo:
uses: grafana/helm-charts/.github/workflows/update-helm-repo.yaml@main
with:
charts_dir: operations/helm/charts
cr_configfile: operations/helm/cr.yaml
ct_configfile: operations/helm/ct.yaml
secrets:
helm_repo_token: ${{ secrets.GH_BOT_ACCESS_TOKEN }}
# See https://github.com/grafana/helm-charts/blob/main/INTERNAL.md about this key
gpg_key_base64: ${{ secrets.HELM_SIGN_KEY_BASE64 }}
5 changes: 4 additions & 1 deletion operations/helm/cr.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
sign: true
git-repo: helm-charts
key: Grafana Loki
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please forgive me, I'm trying to understand how this whole process works at once.

First, this looks like it should probably not say Loki, but rather Mimir. But then, I looked into the chart-releaser README and I see that there's no --key or --sign options, so I'm wondering if this file is correct?

It's possible you just copied this from the helm-charts repo (which I also would have done): https://github.com/grafana/helm-charts/blob/main/cr.yaml

owner: grafana
sign: true
skip-existing: true