Fix ruler config in getting started guide #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Jun 8, 2022
| @@ -103,7 +103,7 @@ In a terminal, run one of the following commands: | |||
| - Using Docker: | |||
|
|
|||
| ```bash | |||
| docker run --rm --name mimir --publish 9009:9009 --volume "$(pwd)"/demo.yaml:/etc/mimir/demo.yaml grafana/mimir:${MIMIR_LATEST} --config.file=/etc/mimir/demo.yaml | |||
| docker run --rm --name mimir --publish 9009:9009 --volume "$(pwd)"/demo.yaml:/etc/mimir/demo.yaml grafana/mimir:latest --config.file=/etc/mimir/demo.yaml | |||
There was a problem hiding this comment.
MIMIR_LATEST environment variable doesn't exist. Since in the previous step we ask to run docker pull grafana/mimir:latest, here we can just use latest.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
jdbaldry
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
#862 made me realized that the getting started guide uses
localstorage for the ruler, which requires the directory to exists and doesn't supportmimirtoolto upload rules config. I recommend to switch tofilesystemwhich fixes #862 and also work withmimirtool. I manually tested it.Which issue(s) this PR fixes or relates to
Fixes #862
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]