Helm: prevent query-scheduler from terminating connections #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
krajorama
approved these changes
Oct 20, 2022
dimitarvdimitrov
deleted the
dimitar/helm-query-scheduler-max-connection-age
branch
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3262-to-release-2.4 origin/release-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 0107f45e0a370ef8ecc1828fd00b52344df12bb5
# Push it to GitHub
git push --set-upstream origin backport-3262-to-release-2.4
git switch main
# Remove the local backport branch
git branch -D backport-3262-to-release-2.4Then, create a pull request where the |
dimitarvdimitrov
added a commit
that referenced
this pull request
Oct 20, 2022
Helm: prevent query-scheduler from terminating connections Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> (cherry picked from commit 0107f45)
|
the mentioned memory leak was fixed in #3302 |
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The query-scheduler periodically terminates connections to the query-frontend and querier. This setting was intended to be a setting for the GEM gateway, but was added to all components. The query frontend has a memory leak when this happens and the queriers abort whole user queries when this happens.
This PR sets the max connection age on the scheduler effectively to infinity, so it doesn't terminate the connections preemptively.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]