Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang.org/x/net for CVE-2022-41717 #3755

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Update golang.org/x/net for CVE-2022-41717 #3755

merged 3 commits into from
Jan 3, 2023

Conversation

andyasp
Copy link
Contributor

@andyasp andyasp commented Dec 16, 2022 •
edited
Loading

What this PR does

Updates golang.org/x/net to v0.4.0 for CVE-2022-41717

From the go issue: golang/go#56350

This issue is also fixed in golang.org/x/net/http2 v0.4.0, for users manually configuring HTTP/2.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@andyasp andyasp force-pushed the aasp/cve-2022-41717 branch from 798edff to ee81b92 Compare December 16, 2022 16:58
@andyasp andyasp marked this pull request as ready for review December 16, 2022 17:00
@andyasp andyasp requested a review from a team as a code owner December 16, 2022 17:00
andyasp
andyasp commented Dec 16, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@andyasp andyasp added security The issue is related to a security vulnerability chore and removed security The issue is related to a security vulnerability labels Dec 16, 2022
pracucci
pracucci approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andy! I haven't been able to find golang.org/x/net changelog / release notes, so I've skimmed through the changes and I can't see anything that would require any change in Mimir.

@pracucci
Copy link
Collaborator

pracucci commented Jan 3, 2023

@andyasp Could you rebase main, please? Then we merge it.

@andyasp andyasp force-pushed the aasp/cve-2022-41717 branch from a9dc643 to f04663a Compare January 3, 2023 14:14
@pracucci pracucci enabled auto-merge (squash) January 3, 2023 15:27
@pracucci pracucci merged commit 0b4d117 into main Jan 3, 2023
@pracucci pracucci deleted the aasp/cve-2022-41717 branch January 3, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyasp @pracucci