Add support for ingesting out-of-order native histograms #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaliao
force-pushed
the
fl/add-ooo-native-histograms-flag
branch
from
ca56ddb
to
a0f7d19
Compare
fionaliao
force-pushed
the
fl/add-ooo-native-histograms-flag
branch
2 times, most recently
from
9e8d017
to
ea66cc9
Compare
fionaliao
force-pushed
the
fl/add-ooo-native-histograms-flag
branch
from
ea66cc9
to
1a4244a
Compare
fionaliao
force-pushed
the
fl/add-ooo-native-histograms-flag
branch
from
aa4b114
to
b966932
Compare
fionaliao
changed the title
fionaliao
requested review from
stevesg,
grafanabot,
a team and
tacole02
as code owners
fionaliao
changed the title
tacole02
approved these changes
Sep 25, 2024
| @@ -3284,6 +3284,12 @@ The `limits` block configures default and per-tenant limits imposed by component | |||
| # CLI flag: -ingester.native-histograms-ingestion-enabled | |||
| [native_histograms_ingestion_enabled: <boolean> | default = false] | |||
|
|
|||
| # (experimental) Enable experimental out-of-order native histogram ingestion. | |||
| # This will only take effect if ingester.out-of-order-time-window is > 0 and if | |||
There was a problem hiding this comment.
Suggested change
| # This will only take effect if ingester.out-of-order-time-window is > 0 and if | |
| # This only takes effect if the `ingester.out-of-order-time-window` value is greater than zero and if |
There was a problem hiding this comment.
| @@ -3284,6 +3284,12 @@ The `limits` block configures default and per-tenant limits imposed by component | |||
| # CLI flag: -ingester.native-histograms-ingestion-enabled | |||
| [native_histograms_ingestion_enabled: <boolean> | default = false] | |||
|
|
|||
| # (experimental) Enable experimental out-of-order native histogram ingestion. | |||
| # This will only take effect if ingester.out-of-order-time-window is > 0 and if | |||
| # ingester.native-histograms-ingestion-enabled = true | |||
There was a problem hiding this comment.
Suggested change
| # ingester.native-histograms-ingestion-enabled = true | |
| # `ingester.native-histograms-ingestion-enabled = true`. |
There was a problem hiding this comment.
krajorama
reviewed
Sep 26, 2024
|
The CHANGELOG has just been cut to prepare for the next release. Please rebase |
fionaliao
force-pushed
the
fl/add-ooo-native-histograms-flag
branch
from
80bf6fe
to
0887714
Compare
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OOO native histogram functionality to Mimir.
The core OOO logic is within prometheus and was synced to mimir-prometheus in grafana/mimir-prometheus#703. This PR just adds a flag to Mimir for enabling out-of-order native histograms and some tests.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #9421
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.