Helm: Add support for dedicated ruler query path #7964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex5517
changed the title
|
@dimitarvdimitrov Sorry for the ping, I wonder if you would have capacity to review this? |
|
i'll take a look later this week; apologies for the delay. At a glance one thing that's missing is a test values file. This is one example. After creating the file and running |
|
I added the tests as requested :) |
Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
approved these changes
May 28, 2024
|
This change will be included in the weekly |
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
* Add support for dedicated ruler query path * Add feature to changelog * Default to false * Add ci test for ruler dedicated query path * rename test file + build tests * update comments * Update operations/helm/charts/mimir-distributed/CHANGELOG.md Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> --------- Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR provides the option to deploy a read path dedicated to the ruler.
This allows you to scale user/dashboards queries independently from the ruler usage.
Another PR that does the same but has no activity #5081
Closes #5081
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.