-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run skopeo
via docker in integration test jobs
#8355
Conversation
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good fix to me. Oops too fast, it doesn't quite work :D
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e)
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e)
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
just noticed latest 2 minor versions are also broken because of skopeo version too old, backport to release 2.12 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-8355-to-release-2.12 origin/release-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 24ae27e41b91f2091f2f6c11744d407ad80ab663
# Push it to GitHub
git push --set-upstream origin backport-8355-to-release-2.12
git switch main
# Remove the local backport branch
git branch -D backport-8355-to-release-2.12 Then, create a pull request where the |
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e)
…TY] (release-2.12) (#8536) * chore(deps): update module github.com/hashicorp/go-retryablehttp to v0.7.7 [security] * Run `skopeo` via docker in integration test jobs (#8355) * run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) (cherry picked from commit 27751d5)
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) (cherry picked from commit 27751d5)
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) (cherry picked from commit 27751d5)
…TY] (release-2.11) (#8537) * chore(deps): update module github.com/hashicorp/go-retryablehttp to v0.7.7 [security] * Use `grafana/doc-validator:v5.1.0` (#8002) It's a version tagged at the same commit as the existing short SHA. Signed-off-by: Jack Baldry <jack.baldry@grafana.com> (cherry picked from commit 70fa416) * Run `skopeo` via docker in integration test jobs (#8355) * run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) (cherry picked from commit 27751d5) * Initialize Tanka with 1.29. (#7544) * Initialize Tanka with 1.29. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Update other refs. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit f62476c) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jack Baldry <jack.baldry@grafana.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-8355-to-mimir-distributed-release-5.3 origin/mimir-distributed-release-5.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 24ae27e41b91f2091f2f6c11744d407ad80ab663
# Push it to GitHub
git push --set-upstream origin backport-8355-to-mimir-distributed-release-5.3
git switch main
# Remove the local backport branch
git branch -D backport-8355-to-mimir-distributed-release-5.3 Then, create a pull request where the |
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e)
* run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
* Run `skopeo` via docker in integration test jobs (#8355) (#9216) * run skopeo via docker in integration tests. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Use fixed version. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Add /tmp volume and path to docker.sock. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Only map /tmp/images. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> --------- Signed-off-by: Peter Štibraný <pstibrany@gmail.com> (cherry picked from commit 24ae27e) Co-authored-by: Peter Štibraný <pstibrany@gmail.com> * [Helm] Release 5.3.1 (#9215) * [Helm] Release 5.3.1 * Update release-notes * Fix docs --------- Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
What this PR does
We run integration tests on
ubuntu-latest
runner, without using build-image. Current ubuntu-latest is ubuntu-22.04, and it has old skopeo version 1.4.1. Even newer (in beta) ubuntu-24.04 still has skopeo version 1.13.3.Since we need to use skopeo 1.14.2 or later to work with Docker 1.25, we try to run it via docker.