Disable logging of migration data when UTF-8 Strict Mode is enabled #9076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates Alertmanager to disable logging of the migration code that assists users to enable UTF-8 Strict Mode. When UTF-8 strict mode is enabled, these logs are no longer needed, and should be disabled to reduce log volume.
grobinson-grafana
force-pushed
the
grobinson/reduce-logging-utf8-strict-mode
branch
from
52d4185
to
37de29b
Compare
grobinson-grafana
changed the title
grobinson-grafana
deleted the
grobinson/reduce-logging-utf8-strict-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This commit disables logging of the migration code that assists users to enable UTF-8 Strict Mode. When UTF-8 strict mode is enabled, these logs are no longer needed, and should be disabled to reduce log volume.
validateMatchersInConfigDescis a special function added to Mimir to log Alertmanager configurations that are incompatible with UTF-8. It does this by unmarshalling each configuration a second time, but with different options and a specialized logger than injects the Tenant ID. It is intended to provide the data to Mimir server operators that helps them identify incompatible tenant configurations before enabling theutf8-strict-modeflag. It's purpose is nothing else but to log this data. Once UTF-8 strict mode is enabled, there is no need to call this function anymore.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.