Remove use of leaf-node round-robin algorithm #9340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
force-pushed
the
casie/remove-round-robin-use
branch
3 times, most recently
from
fb668d5
to
3040c0e
Compare
francoposa
approved these changes
Sep 24, 2024
chencs
force-pushed
the
casie/remove-round-robin-use
branch
from
3040c0e
to
925b4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
At a leaf node,
QueuingAlgorithmisn't used; we simply dequeue from theNode'slocalQueue. To avoid confusion, we will use anilQueuingAlgorithmin these cases, and appendnilto the list of queuing algorithms at tree creation, so the leaf node behavior is always accounted for.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.