MQE: Add support for count aggregation #9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
reviewed
Sep 20, 2024
| } | ||
|
|
||
| for _, p := range data.Floats { | ||
| idx := (p.T - timeRange.StartT) / timeRange.IntervalMs |
There was a problem hiding this comment.
Might be something for a follow up PR, but we have expressions like this in lots of places - what do you think about adding this calculation as a helper method on QueryTimeRange?
There was a problem hiding this comment.
Good idea, will add it later
|
|
||
| for i, havePoint := range g.floatPresent { | ||
| if havePoint { | ||
| t := timeRange.StartT + int64(i)*timeRange.IntervalMs |
There was a problem hiding this comment.
Similar suggestion to above, similarly could be a separate PR: we could add a method to QueryTimeRange to do this calculation.
charleskorn
reviewed
Sep 20, 2024
charleskorn
approved these changes
Sep 20, 2024
jhesketh
force-pushed
the
jhesketh/mqe-aggregations-count
branch
from
2dad30d
to
2f0c7de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.