Fix race in TestMultiDimensionalQueueAlgorithmSlowConsumerEffects #9360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
force-pushed
the
casie/fix-test-race
branch
2 times, most recently
from
0721121
to
69f7602
Compare
chencs
force-pushed
the
casie/fix-test-race
branch
from
69f7602
to
e27791e
Compare
francoposa
reviewed
Sep 24, 2024
| tqa := newTenantQuerierAssignments() | ||
| tqaNonFlipped := newTenantQuerierAssignments() | ||
| tqaFlipped := newTenantQuerierAssignments() | ||
| tqaQuerierWorkerPrioritization := newTenantQuerierAssignments() |
There was a problem hiding this comment.
could just initialize them right in the tree constructor the same way we do the round robin states since we never reference them again, but nbd
There was a problem hiding this comment.
We do reference them again in the treeScenarios initialization
francoposa
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes a race condition introduced to a test by #9190. This race condition is exposed by a idiosyncracy of the test, and would not happen under normal operating conditions.
tenantQuerierAssignments.setup()will (predictably) result in a race if you are reusing the sametenantQuerierAssignmentsvalue for multiple tree queues running in parallel.There's an open question as to whether this test should run all the time, or if it should be changed to a benchmark which is only run at-will. I'm leaving that for @francoposa to decide.
Which issue(s) this PR fixes or relates to
Fixes #9253
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.