Remove localQueueIndex from QueuingAlgorithms #9396
+36
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This subtly changes queuing order, since queuing multiple new nodes at once will push the first element to the end of the queueOrder. However, it does NOT change dequeue order (which is what we care about), since it also updates queuePosition to continue pointing to that first-enqueued element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
With the introduction of leaf-node designations in #8871, we no longer need to maintain local queues on all nodes, and we can instead use
isLeaf()to govern tree traversal decisions.Note that this introduces a subtle difference to the round-robin child queue ordering (
Node.queueOrder) because all enqueued children will be enqueued "behind" the currentqueueOrder[queuePosition]node instead of maintaining a special case. This does not change dequeue order, and is a no-op from the perspective of a caller to the tree.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.