Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deprecated features for 2.14 #9407

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Sep 25, 2024

What this PR does

This PR removes the leftover flags that were deprecated in Mimir 2.12.

Note, I removed a feature per commit, to simplify the review.

Which issue(s) this PR fixes or relates to

Relates to #9382

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…g-grpc-method-limiter

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo requested review from tacole02 and a team as code owners September 25, 2024 12:31
@narqo narqo force-pushed the vldmr/mimir-214-cleanup-deprecated branch 2 times, most recently from 13a9ddb to 87a9ead Compare September 25, 2024 12:55
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
@narqo narqo force-pushed the vldmr/mimir-214-cleanup-deprecated branch from 87a9ead to 634f3de Compare September 25, 2024 13:57
@narqo narqo merged commit 286c23c into main Sep 25, 2024
29 checks passed
@narqo narqo deleted the vldmr/mimir-214-cleanup-deprecated branch September 25, 2024 18:12
grafanabot pushed a commit that referenced this pull request Sep 26, 2024
* ingester, distributor: remove deprecated limit-inflight-requests-using-grpc-method-limiter

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

* querier: remove deprecated -querier.max-query-into-future

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

* update CHANGELOG

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

* rebuild assets

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

---------

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
(cherry picked from commit 286c23c)
narqo added a commit that referenced this pull request Sep 26, 2024
* ingester, distributor: remove deprecated limit-inflight-requests-using-grpc-method-limiter

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

* querier: remove deprecated -querier.max-query-into-future

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

* update CHANGELOG

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

* rebuild assets

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>

---------

Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com>
(cherry picked from commit 286c23c)

Co-authored-by: Vladimir Varankin <vladimir.varankin@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants