-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQE: Add support for increase function #9420
Conversation
Will update changelog once #9419 merges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
I'd like to see some benchmark results for rate
before merging - rate
is one of the most commonly used functions and has a disproportionate impact on resource utilisation as well, so I'd like to be sure there's no regression there.
e8be009
to
adf929e
Compare
I won't add benchmarks for |
Here are the benchmark results vs main:
Shows a small increase between the branches, but there's also a small increase for the prometheus engine. This implies the VM I'm testing on didn't have consistent performance and overall the increase seems okay to me. |
What this PR does
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.