Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple triggers in ScaledObject when using ingest-store ingester autoscaling. #9422

Conversation

pstibrany
Copy link
Member

What this PR does

This PR extends ingest-store support with ability to specify multiple triggers.

Checklist

  • Tests updated.
  • [na] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [na] about-versioning.md updated with experimental features.

@pstibrany pstibrany marked this pull request as ready for review September 26, 2024 10:26
@pstibrany pstibrany requested a review from a team as a code owner September 26, 2024 10:26
Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pracucci pracucci self-requested a review September 26, 2024 14:52
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@narqo
Copy link
Contributor

narqo commented Sep 27, 2024

The CHANGELOG has just been cut to prepare for the next release. Please rebase main and eventually move the CHANGELOG entry added / updated in this PR to the top of the CHANGELOG.md document. Thanks!

…tore ingester autoscaling.

Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
@pstibrany pstibrany force-pushed the add-support-for-multiple-triggers-when-using-ingest-store-autoscaling branch from 13e9054 to c900d70 Compare September 27, 2024 08:11
@pstibrany pstibrany merged commit 9e4c03c into main Sep 27, 2024
29 checks passed
@pstibrany pstibrany deleted the add-support-for-multiple-triggers-when-using-ingest-store-autoscaling branch September 27, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants