Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest-storage: Make label-selector in ReplicaTemplate configurable #9480

Merged
merged 2 commits into from
Sep 30, 2024
Merged

ingest-storage: Make label-selector in ReplicaTemplate configurable #9480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ecf74f
ingest-storage: Make label-selector in ReplicaTemplate configurable
pstibrany Sep 30, 2024
d26ef73
CHANGELOG.md
pstibrany Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

* [ENHANCEMENT] Add `ingest_storage_ingester_autoscaling_triggers` option to specify multiple triggers in ScaledObject created for ingest-store ingester autoscaling. #9422
* [ENHANCEMENT] Add `ingest_storage_ingester_autoscaling_scale_up_stabilization_window_seconds` and `ingest_storage_ingester_autoscaling_scale_down_stabilization_window_seconds` config options to make stabilization window for ingester autoscaling when using ingest-storage configurable. #9445
* [ENHANCEMENT] Make label-selector in ReplicaTemplate/ingester-zone-a object configurable when using ingest-storage. #9480

### Mimirtool

Expand Down
7 changes: 6 additions & 1 deletion operations/mimir/ingest-storage-ingester-autoscaling.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
// to rollout ingesters autoscaling with no downtime.
ingest_storage_ingester_autoscaling_ingester_annotations_enabled: $._config.ingest_storage_ingester_autoscaling_enabled,

// Make label selector in ReplicaTemplate configurable. This mostly doesn't matter, but from our experience if the selector
// doesn't match correct pods, HPA in GKE will display wrong usage in "kubectl describe hpa". This is harmless, but can
// easily be fixed by using name=ingester-zone-a. (We will roll out that change internally, and then upstream).
ingest_storage_replica_template_label_selector: 'name=unused',

// Make triggers configurable so that we can add more. Each object needs to have: query, threshold, metric_type.
ingest_storage_ingester_autoscaling_triggers: [
{
Expand Down Expand Up @@ -75,7 +80,7 @@
assert !$._config.ingest_storage_ingester_autoscaling_enabled || $.rollout_operator_deployment != null : 'partitions ingester autoscaling requires rollout-operator in namespace %s' % $._config.namespace,

// Create resource that will be targetted by ScaledObject.
ingester_primary_zone_replica_template: if !$._config.ingest_storage_ingester_autoscaling_enabled then null else $.replicaTemplate($._config.ingest_storage_ingester_autoscaling_primary_zone, replicas=-1, label_selector='name=unused'),
ingester_primary_zone_replica_template: if !$._config.ingest_storage_ingester_autoscaling_enabled then null else $.replicaTemplate($._config.ingest_storage_ingester_autoscaling_primary_zone, replicas=-1, label_selector=$._config.ingest_storage_replica_template_label_selector),

//
// Configure prepare-shutdown endpoint in all ingesters.
Expand Down
Loading